linux-kernel - Re: [PATCH] mfd: syscon: Add missing struct device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAP1dx+y5GCtx2nnmzwEq20N0J24MYz3WbJgxW80CMHOCcWrS3A@mail.gmail.com>
Date:	Tue, 26 Mar 2013 15:27:27 +0800
From:	Dong Aisheng <dong.aisheng@...aro.org>
To:	Sylwester Nawrocki <s.nawrocki@...sung.com>
Cc:	sameo@...ux.intel.com, kyungmin.park@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: syscon: Add missing struct device_node declaration

On 26 March 2013 00:56, Sylwester Nawrocki <s.nawrocki@...sung.com> wrote:
> syscon.h header uses struct device_node in functions' declarations
> without declaring it. This causes compilation warnings like:
>
> include/linux/mfd/syscon.h:20: warning: ‘struct device_node’
> declared inside parameter list
> include/linux/mfd/syscon.h:20: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Fix it by adding a forward declaration of struct device_node.
>
> Cc: Dong Aisheng <dong.aisheng@...aro.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>

Acked-by: Dong Aisheng <dong.aisheng@...aro.org>

Regards
Dong Aisheng

> ---
>  include/linux/mfd/syscon.h |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 6aeb6b8..f7be936 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -15,6 +15,8 @@
>  #ifndef __LINUX_MFD_SYSCON_H__
>  #define __LINUX_MFD_SYSCON_H__
>
> +struct device_node;
> +
>  extern struct regmap *syscon_node_to_regmap(struct device_node *np);
>  extern struct regmap *syscon_regmap_lookup_by_compatible(const char *s);
>  extern struct regmap *syscon_regmap_lookup_by_phandle(
> --
> 1.7.9.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/