linux-kernel - Re: [GIT PULL] at91: fixes for 3.9-rc #2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201303261105.22173.arnd@arndb.de>
Date:	Tue, 26 Mar 2013 11:05:21 +0000
From:	Arnd Bergmann <arnd@...db.de>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Olof Johansson <olof@...om.net>,
	"Jean-Christophe PLAGNIOL-VILLARD" <plagnioj@...osoft.com>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	"linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] at91: fixes for 3.9-rc #2

On Tuesday 26 March 2013, Nicolas Ferre wrote:
> Indeed, at first sight its looks like a nice solution. But I wonder if
> we add several nodes in this kind of .dtsi files, we may end up with
> mess between APB peripherals and board specific ones like leds, NAND, etc.
> Moreover, the plain and full naming of the node makes it identifiable
> without doubts, even someone not completely familiar with DT.
> 
> I slightly prefer to keep it like this, but I can still change my mind ;-)

If you don't want to use the labels, it's probably better to drop from
the dtsi files. I think you can also write 

ahb/apb/ethernet@...c000 {
	phy-mode = "rmii";
        status = "okay";
};

although I think most people prefer the labels, and I have not tried
the above.

Back to the bug fix, I think we can have a simpler version for 3.9
if you just mark the ethernet node as "disabled" in the 
at91sam9g15.dtsi file, and then do the patch to change the default
in an add-on patch for 3.10.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/