linux-kernel - Re: [Suggestion] kernel: 'now' may be used uninitialized in posix_cpu_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFTL4hw2vc5C9gdf1bm413MftfaYB5PWxTuuU9C5iAuzD_YKEw@mail.gmail.com>
Date:	Tue, 26 Mar 2013 13:27:49 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	tglx@...utronix.de, Greg KH <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Suggestion] kernel: 'now' may be used uninitialized in
 posix_cpu_timer_schedule function

2013/3/26 Chen Gang <gang.chen@...anux.com>:
> Hello Maintainers:
>
>   compiling with EXTRA_CFLAGS=-W:
>     make V=1 EXTRA_CFLAGS=-W ARCH=arm s3c2410_defconfig
>     make V=1 EXTRA_CFLAGS=-W ARCH=arm menuconfig
>       set 'arm-linux-gnu-' for cross chain prefix
>     make V=1 EXTRA_CFLAGS=-W ARCH=arm
>
>   it will report:
>     kernel/posix-cpu-timers.c:1065:19: warning: ‘now’ may be used uninitialized in this function [-Wuninitialized]
>
>   it seems it is really a bug.
>     can any member help to fix it ?
>     or provide additional suggestion ?
>       (it seems only "unsigned long long now = 0" is not enough).

Yeah it's missing a call to cpu_timer_sample_group() before
clear_dead_task(). Andrew Morton reported the warning and I have a
pending patch to fix that. I'm just checking a few other things before
sending it. These clear_dead_task() calls seem to also conflict with
cleanup_timers(). I'm fixing that too.

Thanks for your report!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/