linux-kernel - RE: [PATCH -next v2] mailbox: fix invalid use of sizeof in mailbox_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 Mar 2013 02:07:19 +0000
From:	"Anna, Suman" <s-anna@...com>
To:	Wei Yongjun <weiyj.lk@...il.com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"loic.pallardy@...com" <loic.pallardy@...com>,
	"omar.ramirez@...itl.com" <omar.ramirez@...itl.com>,
	"lugo.fernando@...il.com" <lugo.fernando@...il.com>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next v2] mailbox: fix invalid use of sizeof in
 mailbox_msg_send()

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> sizeof() when applied to a pointer typed expression gives the size of the pointer,
> not that of the pointed data.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/mailbox/mailbox.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mailbox/mailbox.c b/drivers/mailbox/mailbox.c index
> 5fea5c2..78e52c0 100644
> --- a/drivers/mailbox/mailbox.c
> +++ b/drivers/mailbox/mailbox.c
> @@ -83,7 +83,7 @@ int mailbox_msg_send(struct mailbox *mbox, struct
> mailbox_msg *msg)
> 
>  	mutex_lock(&mq->mlock);
> 
> -	if (kfifo_avail(&mq->fifo) < (sizeof(msg) + msg->size)) {
> +	if (kfifo_avail(&mq->fifo) < (sizeof(*msg) + msg->size)) {
>  		ret = -ENOMEM;
>  		goto out;
>  	}
> @@ -93,8 +93,8 @@ int mailbox_msg_send(struct mailbox *mbox, struct
> mailbox_msg *msg)
>  		goto out;
>  	}
> 
> -	len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(msg));
> -	WARN_ON(len != sizeof(msg));
> +	len = kfifo_in(&mq->fifo, (unsigned char *)msg, sizeof(*msg));
> +	WARN_ON(len != sizeof(*msg));
> 
>  	if (msg->size && msg->pdata) {
>  		len = kfifo_in(&mq->fifo, (unsigned char *)msg->pdata,
>

Looks good, thanks. I have added this patch to my branch on github.

Regards
Suman
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/