linux-kernel - Re: [PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130326152310.GA9153@roeck-us.net>
Date:	Tue, 26 Mar 2013 08:23:10 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Hongbo Zhang <hongbo.zhang@...aro.org>
Cc:	khali@...ux-fr.org, lm-sensors@...sensors.org, cbou@...l.ru,
	dwmw2@...radead.org, linaro-kernel@...ts.linaro.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...aro.org,
	lee.jones@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

On Tue, Mar 26, 2013 at 03:06:59PM +0800, Hongbo Zhang wrote:
> Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500
> chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for
> all ABX500s, and the ab8500.c is specific for AB8500 chip. Under this designed
> structure, other chip specific files can be added simply using the same common
> layer abx500.c.
> 
> Signed-off-by: Hongbo Zhang <hongbo.zhang@...aro.org>

Looks good except ...

> diff --git a/drivers/power/ab8500_bmdata.c b/drivers/power/ab8500_bmdata.c
> index d9f1f25..05a1077 100644
> --- a/drivers/power/ab8500_bmdata.c
> +++ b/drivers/power/ab8500_bmdata.c
> @@ -28,8 +28,10 @@ const struct abx500_res_to_temp ab8500_temp_tbl_a_thermistor[] = {
>  	{60, 13437},
>  	{65, 12500},
>  };
> +EXPORT_SYMBOL(ab8500_temp_tbl_a_thermistor);
>  
Those exports should be in the previous patch where you start exporting the symbols,
not in this patch.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/