linux-kernel - Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jJdbDabBjNoaZUeqCT6a6yHqHcQNnqXNM6T1S=bwig8Fw@mail.gmail.com>
Date:	Tue, 26 Mar 2013 08:56:20 -0700
From:	Kees Cook <keescook@...omium.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	Sebastian Gottschall <s.gottschall@...wrt.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"# 3.4.x" <stable@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: Build breakage in 3.8.4 [was: Linux 3.8.4]

On Sun, Mar 24, 2013 at 12:31 PM, Jiri Slaby <jslaby@...e.cz> wrote:
> On 03/20/2013 11:25 PM, Sebastian Gottschall wrote:
>
>> Am 20.03.2013 21:15, schrieb Greg KH:
>>> I'm announcing the release of the 3.8.4 kernel.
> ...
>>>        signal: always clear sa_restorer on execve
>> consider that this kernel is not compileable on mips targets due the
>> patch in kernel/signal.c
>>
>> SA_RESTORER is defined in mips, but sa_restorer does not exist on that
>> platform
>
> The same for ia64...
>
> kernel/signal.c: In function 'flush_signal_handlers':
> kernel/signal.c:441: error: 'struct sigaction' has no member named
> 'sa_restorer'
>
> Do we need this in 3.0, 3.4, 3.8 too?
> commit 522cff142d7d2f9230839c9e1f21a4d8bcc22a4a
> Author: Andrew Morton <akpm@...ux-foundation.org>
> Date:   Wed Mar 13 14:59:34 2013 -0700
>
>     kernel/signal.c: use __ARCH_HAS_SA_RESTORER instead of SA_RESTORER
>
>     __ARCH_HAS_SA_RESTORER is the preferred conditional for use in 3.9 and
>     later kernels, per Kees.

Hrm, if so, we'll need to also backport the changes that aded
__ARCH_HAS_SA_RESTORER...

-Kees

>
> thanks,
> --
> js
> suse labs



--
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/