linux-kernel - Re: [PATCH] staging: vme: fix for a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5151CE72.5090800@ge.com>
Date:	Tue, 26 Mar 2013 16:36:02 +0000
From:	Martyn Welch <martyn.welch@...com>
To:	Kumar Amit Mehta <gmate.amit@...il.com>
CC:	manohar.vanga@...il.com, gregkh@...uxfoundation.org,
	yamanetoshi@...il.com, joe@...ches.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] staging: vme: fix for a potential NULL pointer dereference

On 25/03/13 05:37, Kumar Amit Mehta wrote:
> Audit the return value of cdev_alloc and hence fixes a potential NULL pointer
> dereferencing.
> 
> Signed-off-by: Kumar Amit Mehta <gmate.amit@...il.com>

Looks good to me, thanks.

Signed-off-by: Martyn Welch <martyn.welch@...com>

> ---
>  drivers/staging/vme/devices/vme_user.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c
> index d074b1e..da7f759 100644
> --- a/drivers/staging/vme/devices/vme_user.c
> +++ b/drivers/staging/vme/devices/vme_user.c
> @@ -710,6 +710,10 @@ static int vme_user_probe(struct vme_dev *vdev)
>  
>  	/* Register the driver as a char device */
>  	vme_user_cdev = cdev_alloc();
> +	if (!vme_user_cdev) {
> +		err = -ENOMEM;
> +		goto err_char;
> +	}
>  	vme_user_cdev->ops = &vme_user_fops;
>  	vme_user_cdev->owner = THIS_MODULE;
>  	err = cdev_add(vme_user_cdev, MKDEV(VME_MAJOR, 0), VME_DEVS);
> 


-- 
Martyn Welch (Lead Software Engineer)  | Registered in England and Wales
GE Intelligent Platforms               | (3828642) at 100 Barbirolli Square
T +44(0)1327322748                     | Manchester, M2 3AB
E martyn.welch@...com                  | VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/