linux-kernel - Re: [PATCH v2.1] dw_dmac: make wrapper on of_dma_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohponTj8iHTZqs2pS9m1mOqgbGX5WUDa7B2-xcDP_0sN7ZsQ@mail.gmail.com>
Date:	Tue, 26 Mar 2013 22:46:39 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Vinod Koul <vinod.koul@...el.com>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org,
	spear-devel <spear-devel@...t.st.com>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2.1] dw_dmac: make wrapper on of_dma_controller_register()

On 26 March 2013 22:42, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> Nowadays, besides removal of the -ENODEV checking, it makes probe
> function looks tidier.

Removal of -ENODEV is okay but am not sure if it makes code good :)

This is unnecessary abstraction for just calling a single routine. If that
part was bigger, i would have agreed but to me this wrapper is just
adding abstraction and nothing more.

--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/