linux-kernel - Re: [PATCH v2.2] dw_dmac: remove unnecessary ENODEV check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpomxgQy0f51nYePaKs03Us4zfxQy+-_C6J9kYqNK8_iJoQ@mail.gmail.com>
Date:	Tue, 26 Mar 2013 23:01:34 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Vinod Koul <vinod.koul@...el.com>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org,
	spear-devel <spear-devel@...t.st.com>,
	Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v2.2] dw_dmac: remove unnecessary ENODEV check

On 26 March 2013 22:59, Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
> If CONFIG_OF is not set the of_node of the device will always be NULL.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/dma/dw_dmac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index 274fd7d..736cffa 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -1846,7 +1846,7 @@ static int dw_probe(struct platform_device *pdev)
>         if (pdev->dev.of_node) {
>                 err = of_dma_controller_register(pdev->dev.of_node,
>                                                  dw_dma_of_xlate, dw);
> -               if (err && err != -ENODEV)
> +               if (err)
>                         dev_err(&pdev->dev,
>                                 "could not register of_dma_controller\n");

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/