[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20130325220150.af9795a7.akpm@linux-foundation.org>
Date: Mon, 25 Mar 2013 22:01:50 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Rusty Russell <rusty@...tcorp.com.au>
Cc: Alexandru Gheorghiu <gheorghiuandru@...il.com>,
"Michael S. Tsirkin" <mst@...hat.com>,
virtualization@...ts.linux-foundation.org,
linux-kernel@...r.kernel.org,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
Subject: Re: [PATCH] drivers: virtio: Use PTR_RET function
On Tue, 26 Mar 2013 13:57:09 +1030 Rusty Russell <rusty@...tcorp.com.au> wrote:
> Alexandru Gheorghiu <gheorghiuandru@...il.com> writes:
>
> > Used PTR_RET function instead of IS_ERR and PTR_ERR.
> > Patch found using coccinelle.
>
> WTF is PTR_RET? PTR_RET doesn't return anything. Why is it called
> that? It doesn't even make sense.
>
> ZERO_OR_PTR_ERR() maybe.
>
> But what problem are we solving? Insufficient churn in the tree? Code
> being too readable? This isn't some hard-to-get right corner case, or a
> missed optimization.
>
> Andrew, what am I missing here?
It seemed like a good idea at the time. Merged it two years ago and
have since been keenly awaiting an opportunity to use it.
It seems that people _have_ been using it, but mainly netfilter people
and we know they're all crazy ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists