linux-kernel - Re: [PATCH] perf: add callgrind conversion tool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+BNSkUiNyB_mpsmHa2QQMGBmG+YQ+0De2ApC1AuVRdrWFYOXw@mail.gmail.com>
Date:	Tue, 26 Mar 2013 11:52:10 -0700
From:	Roberto Vitillo <ravitillo@....gov>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	paulus@...ba.org, mingo@...hat.com, acme@...stprotocols.net,
	rostedt@...dmis.org
Subject: Re: [PATCH] perf: add callgrind conversion tool

>>  LIB_OBJS += $(OUTPUT)ui/setup.o
>>  LIB_OBJS += $(OUTPUT)ui/helpline.o
>> @@ -528,6 +532,7 @@ BUILTIN_OBJS += $(OUTPUT)builtin-kmem.o
>>  BUILTIN_OBJS += $(OUTPUT)builtin-lock.o
>>  BUILTIN_OBJS += $(OUTPUT)builtin-kvm.o
>>  BUILTIN_OBJS += $(OUTPUT)builtin-inject.o
>> +BUILTIN_OBJS += $(OUTPUT)builtin-convert.o
>
> You can make these conditional after checking availibility of bfd.
Ok

> AFAICS this cg_cnv_sample() does nothing with converting.  Why did you
> move the code to a different file rather than keeping it together?
Good point, there isn't really a good reason to have this in a separate file.

> The name of the function doesn't look good to me.  Maybe hists__convert_symbols?
Agreed, it's confusing.

>> +     /* Needed to display correctly the inlining relationship in kcachegrind */
>> +     if (ret_caller && caller_line)
>> +             fprintf(output, "fl=%s\n0 0\n", caller_name);
>> +
>> +     if (ret_callee && last_line)
>> +             fprintf(output, "fl=%s\n", last_source_name);
>> +     else
>> +             fprintf(output, "fl=\n");
>
> Could you explain why this empty fl line is needed?
Without the empty fl statement kcachegrind would apply the last valid fl
statement in the file.

Thanks,
Roberto
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/