linux-kernel - Re: [PATCH] clk: ux500: Fix prcmu clocks registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130326200533.4014.81236@quantum>
Date:	Tue, 26 Mar 2013 13:05:33 -0700
From:	Mike Turquette <mike.turquette@...aro.org>
To:	Maxime Coquelin <maxime_coquelin@...oo.fr>,
	linux-kernel@...r.kernel.org
Cc:	Maxime Coquelin <maxime.coquelin@...com>
Subject: Re: [PATCH] clk: ux500: Fix prcmu clocks registration

Quoting Maxime Coquelin (2013-03-26 07:27:15)
> From: Maxime Coquelin <maxime.coquelin@...com>
> 
> In clk_reg_prcmu(), clk->hw.init field is assigned with a
> reference local to clk_reg_prcmu() function.
> 
> This patch replaces references to clk->hw.init with calls
> to __clk_get_name when called after clock registration.
> 
> This patch applies on top of v3.9-rc4.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@...com>
> Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Hi Maxime,

This patch did not apply cleanly onto clk-next.  Below is what I merged.
Please let me know if there are any issues.

Regards,
Mike



>From 5717b1a93c7d86cfea501a35bb8c83910c20159f Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin@...com>
Date: Tue, 26 Mar 2013 15:27:15 +0100
Subject: [PATCH] clk: ux500: Fix prcmu clocks registration

In clk_reg_prcmu(), clk->hw.init field is assigned with a
reference local to clk_reg_prcmu() function.

This patch replaces references to clk->hw.init with calls
to __clk_get_name when called after clock registration.

This patch applies on top of v3.9-rc4.

Signed-off-by: Maxime Coquelin <maxime.coquelin@...com>
Acked-by: Ulf Hansson <ulf.hansson@...aro.org>
Signed-off-by: Mike Turquette <mturquette@...aro.org>
[mturquette@...aro.org: resolved trivial merge issues]
---
 drivers/clk/ux500/clk-prcmu.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/ux500/clk-prcmu.c b/drivers/clk/ux500/clk-prcmu.c
index 9d83256..293a288 100644
--- a/drivers/clk/ux500/clk-prcmu.c
+++ b/drivers/clk/ux500/clk-prcmu.c
@@ -44,7 +44,7 @@ static void clk_prcmu_unprepare(struct clk_hw *hw)
 	struct clk_prcmu *clk = to_clk_prcmu(hw);
 	if (prcmu_request_clock(clk->cg_sel, false))
 		pr_err("clk_prcmu: %s failed to disable %s.\n", __func__,
-			hw->init->name);
+			__clk_get_name(hw->clk));
 	else
 		clk->is_prepared = 0;
 }
@@ -106,7 +106,7 @@ static int clk_prcmu_opp_prepare(struct clk_hw *hw)
 						100);
 		if (err) {
 			pr_err("clk_prcmu: %s fail req APE OPP for %s.\n",
-				__func__, hw->init->name);
+				__func__, __clk_get_name(hw->clk));
 			return err;
 		}
 		clk->opp_requested = 1;
@@ -130,7 +130,7 @@ static void clk_prcmu_opp_unprepare(struct clk_hw *hw)
 
 	if (prcmu_request_clock(clk->cg_sel, false)) {
 		pr_err("clk_prcmu: %s failed to disable %s.\n", __func__,
-			hw->init->name);
+			__clk_get_name(hw->clk));
 		return;
 	}
 
@@ -152,7 +152,7 @@ static int clk_prcmu_opp_volt_prepare(struct clk_hw *hw)
 		err = prcmu_request_ape_opp_100_voltage(true);
 		if (err) {
 			pr_err("clk_prcmu: %s fail req APE OPP VOLT for %s.\n",
-				__func__, hw->init->name);
+				__func__, __clk_get_name(hw->clk));
 			return err;
 		}
 		clk->opp_requested = 1;
@@ -175,7 +175,7 @@ static void clk_prcmu_opp_volt_unprepare(struct clk_hw *hw)
 
 	if (prcmu_request_clock(clk->cg_sel, false)) {
 		pr_err("clk_prcmu: %s failed to disable %s.\n", __func__,
-			hw->init->name);
+			__clk_get_name(hw->clk));
 		return;
 	}
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/