linux-kernel - Re: [PATCHv2 01/02] block: removes dynamic allocation on stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130326205128.GV19488@kernel.dk>
Date:	Tue, 26 Mar 2013 14:51:28 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	"Philip J. Kelleher" <pjk1939@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, klebers@...ux.vnet.ibm.com
Subject: Re: [PATCHv2 01/02] block: removes dynamic allocation on stack

On Tue, Mar 26 2013, Philip J. Kelleher wrote:
> From: Philip J Kelleher <pjk1939@...ux.vnet.ibm.com>
> 
> Removing the dynamic allocation on the stack.
> 
> Signed-off-by: Philip J Kelleher <pjk1939@...ux.vnet.ibm.com>
> -------------------------------------------------------------------------------
> o Version 2 consists of the error checking that was foolishly left out.
> o Added error checking to multiple functions to support the dynamically
>   allocated list_head array.

I've been fixing up your patch formats for a while now, lets please just
improve on it a little bit. First of all, your subject line should be
prefixed with the driver name. So just use rsxx or similar. Secondly,
for this patch, you are using the same subject line as the original
patch. This is a fixup patch, it should be labelled as such. A proper
subject line for this patch would be:

rsxx: enable error return of rsxx_eeh_save_issued_dmas()

and the body could be:

Commit d8d595df introduced a bug where we did not check for a NULL
return from kmalloc(). Make rsxx_eeh_save_issued_dmas() return an
error for that case, and make the callers handle that.

You appear to put the description of the patch in a section below your
signed-off-by, which doesn't really work. Your --- divider gets broken
with git am as well.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/