linux-kernel - Re: [RFC, 2/5] Thermal: thermal framework registration failure case cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51521FA8.6030806@ti.com>
Date:	Tue, 26 Mar 2013 18:22:32 -0400
From:	Eduardo Valentin <eduardo.valentin@...com>
To:	Zhang Rui <rui.zhang@...el.com>
CC:	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<amit.daniel@...sung.com>, <durgadoss.r@...el.com>, <andi@...as.de>
Subject: Re: [RFC, 2/5] Thermal: thermal framework registration failure case
 cleanup

On 26-03-2013 12:26, Zhang Rui wrote:
> Signed-off-by: Zhang Rui <rui.zhang@...el.com>
>

Could you please describe why these resource releases are not required 
anymore? Even on thermal_exit.

> ---
> drivers/thermal/thermal_core.c |   12 ++----------
>   1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 5b7863a..845ed6e 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -1863,13 +1863,9 @@ static int __init thermal_init(void)
>   	int result = 0;
>
>   	result = class_register(&thermal_class);
> -	if (result) {
> -		idr_destroy(&thermal_tz_idr);
> -		idr_destroy(&thermal_cdev_idr);
> -		mutex_destroy(&thermal_idr_lock);
> -		mutex_destroy(&thermal_list_lock);
> +	if (result)
>   		return result;
> -	}
> +
>   	result = genetlink_init();
>   	return result;
>   }
> @@ -1877,10 +1873,6 @@ static int __init thermal_init(void)
>   static void __exit thermal_exit(void)
>   {
>   	class_unregister(&thermal_class);
> -	idr_destroy(&thermal_tz_idr);
> -	idr_destroy(&thermal_cdev_idr);
> -	mutex_destroy(&thermal_idr_lock);
> -	mutex_destroy(&thermal_list_lock);
>   	genetlink_exit();
>   }
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/