linux-kernel - Re: [patch v2] sound/soc/codecs : fix build failure for next-20130325

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130327133915.GU18316@opensource.wolfsonmicro.com>
Date:	Wed, 27 Mar 2013 13:39:16 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Xiong Zhou <jencce.kernel@...il.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [patch v2] sound/soc/codecs : fix build failure for next-20130325

On Wed, Mar 27, 2013 at 09:31:33PM +0800, Xiong Zhou wrote:

> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 18fea10..f38af70 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -79,7 +79,6 @@ config SND_SOC_ALL_CODECS
>  	select SND_SOC_WM0010 if SPI_MASTER
>  	select SND_SOC_WM1250_EV1 if I2C
>  	select SND_SOC_WM2000 if I2C
> -	select SND_SOC_WM2200 if I2C
>  	select SND_SOC_WM5100 if I2C
>  	select SND_SOC_WM5102 if MFD_WM5102
>  	select SND_SOC_WM5110 if MFD_WM5110
> @@ -370,6 +369,7 @@ config SND_SOC_WM2000
>  	tristate
>  
>  config SND_SOC_WM2200
> +	depends on SND_SOC_ARIZONA && I2C
>  	tristate

I really don't understand this at all, removing something from
ALL_CODECS is not a good idea.  This isn't a Kconfig issue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)