linux-kernel - Re: [PATCH] tg3: fix length overflow in VPD firmware parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130327.141126.2163700256471831702.davem@davemloft.net>
Date:	Wed, 27 Mar 2013 14:11:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	keescook@...omium.org
Cc:	linux-kernel@...r.kernel.org, mcarlson@...adcom.com,
	mchan@...adcom.com, netdev@...r.kernel.org, oded@...vatecore.com,
	spender@...ecurity.net, benli@...adcom.com
Subject: Re: [PATCH] tg3: fix length overflow in VPD firmware parsing

From: Kees Cook <keescook@...omium.org>
Date: Wed, 27 Mar 2013 09:40:50 -0700

> Commit 184b89044fb6e2a74611dafa69b1dce0d98612c6 ("tg3: Use VPD fw version
> when present") introduced VPD parsing that contained a potential length
> overflow.
> 
> Limit the hardware's reported firmware string length (max 255 bytes) to
> stay inside the driver's firmware string length (32 bytes). On overflow,
> truncate the formatted firmware string instead of potentially overwriting
> portions of the tg3 struct.
> 
> http://cansecwest.com/slides/2013/PrivateCore%20CSW%202013.pdf
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>
> Reported-by: Oded Horovitz <oded@...vatecore.com>
> Reported-by: Brad Spengler <spender@...ecurity.net>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/