linux-kernel - Re: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 Mar 2013 12:50:50 -0700
From:	Kent Overstreet <koverstreet@...gle.com>
To:	Randy Dunlap <rdunlap@...radead.org>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH -next 1/3] bcache: Add missing #include <linux/prefetch.h>

On Wed, Mar 27, 2013 at 11:27:58AM -0700, Randy Dunlap wrote:
> On 03/27/13 11:21, Kent Overstreet wrote:
> > On Wed, Mar 27, 2013 at 06:56:28PM +0100, Geert Uytterhoeven wrote:
> >> m68k/allmodconfig:
> >>
> >> drivers/md/bcache/bset.c: In function ‘bset_search_tree’:
> >> drivers/md/bcache/bset.c:727: error: implicit declaration of function ‘prefetch’
> >>
> >> drivers/md/bcache/btree.c: In function ‘bch_btree_node_get’:
> >> drivers/md/bcache/btree.c:933: error: implicit declaration of function ‘prefetch’
> > 
> > Thanks, applied! The other two I already have a patch queued up for.
> 
> 
> On i386 and x86_64, I also see this build problem:
> 
> drivers/md/bcache/bset.c:885:4: error: implicit declaration of function '__WARN' [-Werror=implicit-function-declaration]
> 
> 
> Do you also have a patch for it?

Nope - looks like __WARN() doesn't exist if CONFIG_BUG=n, whoops.

Adding this to the queue:

commit 796c213186b850b3e6e8d5fd5799b0fd74721ea3
Author: Kent Overstreet <koverstreet@...gle.com>
Date:   Wed Mar 27 12:47:45 2013 -0700

    bcache: Use WARN_ONCE() instead of __WARN()
    
    Signed-off-by: Kent Overstreet <koverstreet@...gle.com>

diff --git a/drivers/md/bcache/bset.c b/drivers/md/bcache/bset.c
index d4f2164..cb4578a 100644
--- a/drivers/md/bcache/bset.c
+++ b/drivers/md/bcache/bset.c
@@ -883,7 +883,7 @@ struct bkey *bch_btree_iter_next(struct btree_iter *iter)
 		iter->data->k = bkey_next(iter->data->k);
 
 		if (iter->data->k > iter->data->end) {
-			__WARN();
+			WARN_ONCE(1, "bset was corrupt!\n");
 			iter->data->k = iter->data->end;
 		}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/