linux-kernel - Re: [PATCH] power: pass IRQF_ONESHOT to request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130328010611.GV18316@opensource.wolfsonmicro.com>
Date:	Thu, 28 Mar 2013 01:06:12 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Andrei Epure <epure.andrei@...il.com>
Cc:	cbou@...l.ru, dwmw2@...radead.org, milo.kim@...com,
	linux-kernel@...r.kernel.org, patches@...nsource.wolfsonmicro.com
Subject: Re: [PATCH] power: pass IRQF_ONESHOT to request_threaded_irq()

On Thu, Mar 28, 2013 at 02:42:50AM +0200, Andrei Epure wrote:
> Patch found using coccinelle.
> 
> Signed-off-by: Andrei Epure <epure.andrei@...il.com>

Some of these may be false positives especially for PMICs - often the
interrupts are guaranteed to be generated from the interrupt controller
on the device which runs in thread context.

More generally though why not fix this in request_threaded_irq() itself,
if there's no hard IRQ handler then add the flag transparently?  It'd
save boilerplate.  Indeed I could've sworn someone did that...

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)