linux-kernel - Re: [PATCH 04/33] aio: remove retry-based AIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130328142002.GD4989@thunk.org>
Date:	Thu, 28 Mar 2013 10:20:02 -0400
From:	Theodore Ts'o <tytso@....edu>
To:	Kent Overstreet <koverstreet@...gle.com>
Cc:	linux-kernel@...r.kernel.org, linux-aio@...ck.org,
	akpm@...ux-foundation.org, Zach Brown <zab@...hat.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mark Fasheh <mfasheh@...e.com>,
	Joel Becker <jlbec@...lplan.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Jens Axboe <axboe@...nel.dk>,
	Asai Thambi S P <asamymuthupa@...ron.com>,
	Selvan Mani <smani@...ron.com>,
	Sam Bradshaw <sbradshaw@...ron.com>,
	Jeff Moyer <jmoyer@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Benjamin LaHaise <bcrl@...ck.org>
Subject: Re: [PATCH 04/33] aio: remove retry-based AIO

On Thu, Mar 21, 2013 at 09:35:25AM -0700, Kent Overstreet wrote:
> From: Zach Brown <zab@...hat.com>
> 
> This removes the retry-based AIO infrastructure now that nothing in tree
> is using it.
> 
> We want to remove retry-based AIO because it is fundemantally unsafe.  It
> retries IO submission from a kernel thread that has only assumed the mm of
> the submitting task.  All other task_struct references in the IO
> submission path will see the kernel thread, not the submitting task.  This
> design flaw means that nothing of any meaningful complexity can use
> retry-based AIO.
> 
> This removes all the code and data associated with the retry machinery.
> The most significant benefit of this is the removal of the locking around
> the unused run list in the submission path.
> 
> This has only been compiled.
> 
> Signed-off-by: Kent Overstreet <koverstreet@...gle.com>
> Signed-off-by: Zach Brown <zab@...hat.com>

Reviewed-by: "Theodore Ts'o" <tytso@....edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/