linux-kernel - Re: [PATCH] compat/compat-drivers/linux-next: fb skip_vt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130328083943.01e61b4b@jbarnes-desktop>
Date:	Thu, 28 Mar 2013 08:39:43 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	"Luis R. Rodriguez" <mcgrof@...not-panic.com>
Cc:	FlorianSchandinat@....de, linux-fbdev@...r.kernel.org,
	dri-devel@...ts.freedesktop.org, backports@...r.kernel.org,
	cocci@...teme.lip6.fr, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr, rodrigo.vivi@...il.com,
	daniel.vetter@...ll.ch, rafael.j.wysocki@...el.com
Subject: Re: [PATCH] compat/compat-drivers/linux-next: fb skip_vt_switch

On Thu, 28 Mar 2013 05:04:26 -0700
"Luis R. Rodriguez" <mcgrof@...not-panic.com> wrote:

> The new commit by Jesse that extended the fb_info with a skip_vt_switch
> element is the simplest example of a data structure expansion. We'd backport
> this by adding a static inline to compat so that new kernels muck with the
> new element and for older kernels this would be a no-op. This reduces the
> size of the backport and unclutters the required patch with #idefs, and
> insteads leaves only a replacement of the usage of the new elements with
> a static inline, this however would still be required on our end:
> 
> 	-      info->skip_vt_switch = true;
> 	+      fb_enable_skip_vt_switch(info);
> 
> So we'd then have to just add this static inline change for each new driver...
> There may be a way to get SmPL to do this for us...

Yeah I'm not attached to the direct structure reference; a couple of
inlines are just as easy to read.  So no argument from me.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/