lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 28 Mar 2013 13:00:39 -0400 From: Jason Cooper <jason@...edaemon.net> To: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> Cc: Andrew Lunn <andrew@...n.ch>, Russell King <linux@....linux.org.uk>, linux-kernel@...r.kernel.org, Soeren Moch <smoch@....de>, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] ARM: Kirkwood: fix unused mvsdio gpio pins On Sat, Mar 23, 2013 at 01:56:58PM +0100, Sebastian Hesselbarth wrote: > mvsdio_platform_data allows to pass card detect and write protect gpio > numbers to the driver. Some kirkwood boards don't use both pins as they > are not connected, and don't set the corresponding value in platform_data. > > This will leave the unset values in platform_data initialized as 0, which > is in fact a valid gpio pin. mvsdio will grab that pin and configure it as > gpio, which in turn breaks nand controller as mpp0 also carries nand_io2. > > This patch fixes the above by initializing unused gpio functions in the > platform_data with an invalid (-1) value. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com> > Reported-by: Soeren Moch <smoch@....de> > --- > Cc: Soeren Moch <smoch@....de> > Cc: Jason Cooper <jason@...edaemon.net> > Cc: Andrew Lunn <andrew@...n.ch> > Cc: Russell King <linux@....linux.org.uk> > Cc: linux-arm-kernel@...ts.infradead.org > Cc: linux-kernel@...r.kernel.org > --- > arch/arm/mach-kirkwood/guruplug-setup.c | 2 ++ > arch/arm/mach-kirkwood/openrd-setup.c | 1 + > arch/arm/mach-kirkwood/rd88f6281-setup.c | 1 + > 3 files changed, 4 insertions(+) Applied to mvebu/fixes thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists