linux-kernel - Re: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130328.140057.1029413611130335133.davem@davemloft.net>
Date:	Thu, 28 Mar 2013 14:00:57 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	tgraf@...g.ch
Cc:	honkiko@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH 1/6] net-next: replace obsolete NLMSG_* with type safe
 nlmsg_*

From: Thomas Graf <tgraf@...g.ch>
Date: Thu, 28 Mar 2013 14:32:16 +0000

> On 03/28/13 at 12:47am, Hong Zhiguo wrote:
>> diff --git a/net/ipv4/udp_diag.c b/net/ipv4/udp_diag.c
>> index 505b30a..467fb92 100644
>> --- a/net/ipv4/udp_diag.c
>> +++ b/net/ipv4/udp_diag.c
>> @@ -64,9 +64,9 @@ static int udp_dump_one(struct udp_table *tbl, struct sk_buff *in_skb,
>>  		goto out;
>>  
>>  	err = -ENOMEM;
>> -	rep = alloc_skb(NLMSG_SPACE((sizeof(struct inet_diag_msg) +
>> -				     sizeof(struct inet_diag_meminfo) +
>> -				     64)), GFP_KERNEL);
>> +	rep = nlmsg_new(sizeof(struct inet_diag_msg) +
>> +				     sizeof(struct inet_diag_meminfo) + 64,
>> +				     GFP_KERNEL);
> 
> This is formatted incorrectly, otherwise the patch looks good.

I'll fix it up when I commit.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/