linux-kernel - Re: [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130328181425.GE3368@n2100.arm.linux.org.uk>
Date:	Thu, 28 Mar 2013 18:14:26 +0000
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Jason Cooper <jason@...edaemon.net>
Cc:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dove: fix Dove cpu type from V7 to PJ4

On Thu, Mar 28, 2013 at 01:06:54PM -0400, Jason Cooper wrote:
> On Sat, Mar 23, 2013 at 04:06:51PM +0100, Sebastian Hesselbarth wrote:
> > The CPU used in Marvell Dove SoCs is a PJ4 Sheeva core. Using
> > CONFIG_CPU_PJ4 instead of CONFIG_CPU_V7 will also allow to enable
> > iWMMXt extensions on Dove.
> > 
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> > ---
> > Cc: Russell King <linux@....linux.org.uk>
> > Cc: Jason Cooper <jason@...edaemon.net>
> > Cc: Andrew Lunn <andrew@...n.ch>
> > Cc: linux-arm-kernel@...ts.infradead.org
> > Cc: linux-kernel@...r.kernel.org
> > ---
> >  arch/arm/Kconfig |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Hmmm, I'm getting (with dove_defconfig):
> 
> arch/arm/kernel/built-in.o: In function `iwmmxt_do':
> /.../arch/arm/kernel/pj4-cp0.c:36: undefined reference to `iwmmxt_task_release'
> /.../arch/arm/kernel/pj4-cp0.c:40: undefined reference to `iwmmxt_task_switch'
> make: *** [vmlinux] Error 1

Looks to me like PJ4 IWMMXT support wasn't properly tested out when it
was submitted - it's possible to end up with pj4-cp0.c built without
the IWMMXT code that it depends on being built...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/