linux-kernel - Re: [PATCH v3] ARM: add support for context tracking subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <871uaz425z.fsf@linaro.org>
Date:	Thu, 28 Mar 2013 14:58:32 -0700
From:	Kevin Hilman <khilman@...aro.org>
To:	Russell King <rmk+kernel@....linux.org.uk>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	Mats Liljegren <mats.liljegren@...a.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH v3] ARM: add support for context tracking subsystem

Kevin Hilman <khilman@...aro.org> writes:

> commit 91d1aa43 (context_tracking: New context tracking susbsystem)
> generalized parts of the RCU userspace extended quiescent state into
> the context tracking subsystem.  Context tracking is then used
> to implement adaptive tickless (a.k.a extended nohz)
>
> To support the new context tracking subsystem on ARM, the user/kernel
> boundary transtions need to be instrumented.
>
> For exceptions and IRQs in usermode, the existing usr_entry macro is
> used to instrument the user->kernel transition.  For the return to
> usermode path, the ret_to_user* path is instrumented.  Using the
> usr_entry macro, this covers interrupts in userspace, data abort and
> prefetch abort exceptions in userspace as well as undefined exceptions
> in userspace (which is where FP emulation and VFP are handled.)
>
> For syscalls, the slow return path is covered by instrumenting the
> ret_to_user path.  In addition, the syscall entry point is
> instrumented which covers the user->kernel transition for both fast
> and slow syscalls, and an additional instrumentation point is added
> for the fast syscall return path (ret_fast_syscall).
>
> Cc: Mats Liljegren <mats.liljegren@...a.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Signed-off-by: Kevin Hilman <khilman@...aro.org>

This version has been submitted to Russell's patch tracker as patch
7688[1] after making the minor change below.

[...]

> diff --git a/arch/arm/kernel/entry-armv.S b/arch/arm/kernel/entry-armv.S
> index 0f82098..3449d30 100644
> --- a/arch/arm/kernel/entry-armv.S
> +++ b/arch/arm/kernel/entry-armv.S
> @@ -396,6 +396,7 @@ ENDPROC(__pabt_svc)
>  #ifdef CONFIG_IRQSOFF_TRACER
>  	bl	trace_hardirqs_off
>  #endif
> +	ct_user_exit, save = 0
>  	.endm

Removed the ',' after the macro here an elsewhere.  

It's harmless, but not needed and removing it makes this look like other
macro usage throughout.

Kevin

[1] http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7688/1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/