linux-kernel - Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 28 Mar 2013 22:32:53 +0000
From:	David Howells <dhowells@...hat.com>
To:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
Cc:	dhowells@...hat.com,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] xhci: Rename SEGMENT_SIZE and SEGMENT_SHIFT as the former is used in a.out.h

Sarah Sharp <sarah.a.sharp@...ux.intel.com> wrote:

> I'm a little bit confused about your description for the second one.
> Did you need to change the #defines names because they could conflict
> with other drivers when the xHCI driver is built in?  Or is there some
> other point I'm missing?

Sorry, I should say.  I'm trying to clean up the UAPI headers and I noticed
that the xHCI SEGMENT_SIZE macro is named the same as one defined by a.out.h
that cannot be changed as it is seen by userspace.  Although it's unlikely
that within the kernel they are unlikely to collide, one cannot be entirely
sure that will stay true as new arches get added (hopefully no one will add
new arches that use a.out format).  It seems best that the xHCI one be renamed
if possible.

> Are these feature patches for 3.10, or bug fixes for 3.9?  If they're
> for 3.9, should they go into stable?  My inclination is the first patch
> shouldn't but I'm not sure about this one.

Both are aimed at 3.10.  Neither are fixes for extant bugs that I know of.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/