linux-kernel - Re: [PATCH V4] i2c: davinci: update to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130329111709.GA6359@the-dreams.de>
Date:	Fri, 29 Mar 2013 12:17:09 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	"Vishwanathrao Badarkhe, Manish" <manishv.b@...com>
Cc:	davinci-linux-open-source@...ux.davincidsp.com,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
	nsekhar@...com, khilman@...prootsystems.com, ben-linux@...ff.org,
	w.sang@...gutronix.de
Subject: Re: [PATCH V4] i2c: davinci: update to devm_* API

On Tue, Mar 05, 2013 at 05:14:45PM +0530, Vishwanathrao Badarkhe, Manish wrote:
> Update the code to use devm_* API so that driver
> core will manage resources.
> 
> Signed-off-by: Vishwanathrao Badarkhe, Manish <manishv.b@...com>

Applied the following fix:

> +	dev->base = devm_ioremap_resource(&pdev->dev, mem);
> +	if (IS_ERR(dev->base)) {
> +		r = PTR_ERR(dev->base);
> +		dev_err(&pdev->dev, "I2C region already claimed\n");
> +		goto err_unuse_clocks;

No dev_err after devm_ioremap_resource. make coccicheck will tell you
about this.

Otherwise: Applied to for-next, thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/