linux-kernel - Re: [PATCH] drivers/char/ipmi: memcpy, need additional 2 bytes to avoid memory overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51559C4A.7060905@acm.org>
Date:	Fri, 29 Mar 2013 08:51:06 -0500
From:	Corey Minyard <tcminyard@...il.com>
To:	Chen Gang <gang.chen@...anux.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	openipmi-developer@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/char/ipmi: memcpy, need additional 2 bytes to
 avoid memory overflow

Yes, this is correct, I've pulled it into my tree.

-corey

On 03/29/2013 02:18 AM, Chen Gang wrote:
>    when calling memcpy, read_data and write_data need additional 2 bytes.
>
>    write_data:
>      for checking:  "if (size > IPMI_MAX_MSG_LENGTH)"
>      for operating: "memcpy(bt->write_data + 3, data + 1, size - 1)"
>
>    read_data:
>      for checking:  "if (msg_len < 3 || msg_len > IPMI_MAX_MSG_LENGTH)"
>      for operating: "memcpy(data + 2, bt->read_data + 4, msg_len - 2)"
>
>
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>   drivers/char/ipmi/ipmi_bt_sm.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
> index cdd4c09f..a22a7a5 100644
> --- a/drivers/char/ipmi/ipmi_bt_sm.c
> +++ b/drivers/char/ipmi/ipmi_bt_sm.c
> @@ -95,9 +95,9 @@ struct si_sm_data {
>   	enum bt_states	state;
>   	unsigned char	seq;		/* BT sequence number */
>   	struct si_sm_io	*io;
> -	unsigned char	write_data[IPMI_MAX_MSG_LENGTH];
> +	unsigned char	write_data[IPMI_MAX_MSG_LENGTH + 2]; /* +2 for memcpy */
>   	int		write_count;
> -	unsigned char	read_data[IPMI_MAX_MSG_LENGTH];
> +	unsigned char	read_data[IPMI_MAX_MSG_LENGTH + 2]; /* +2 for memcpy */
>   	int		read_count;
>   	int		truncated;
>   	long		timeout;	/* microseconds countdown */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/