linux-kernel - Re: [PATCH 07/33] regulator: ab8500-ext: Add suspend support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130329174458.GF18316@opensource.wolfsonmicro.com>
Date:	Fri, 29 Mar 2013 17:44:58 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-kernel@...r.kernel.org,
	Bengt Jonsson <bengt.g.jonsson@...ricsson.com>
Subject: Re: [PATCH 07/33] regulator: ab8500-ext: Add suspend support

On Thu, Mar 28, 2013 at 04:11:07PM +0000, Lee Jones wrote:

> +static int ab8500_ext_regulator_set_suspend_enable(struct regulator_dev *rdev)
> +{
> +	dev_dbg(rdev_get_dev(rdev), "suspend: ");

It's kind of a general problem with the AB8500 code but there's an awful
lot of content free trace like this, if there's not adequate trace in
the core for things like that we should add it there.

> +
> +	return ab8500_ext_regulator_enable(rdev);
> +}
> +

This looks broken - it's going to interfere with the normal runtime
operation of the device as it's using exactly the same operation to
change the device state.  If the hardware doesn't have any support for
suspend mode then the driver shouldn't be implementing this function.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)