linux-kernel - RE: e1000e + suspend, 3.9-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Mar 2013 18:04:42 +0000
From:	"Allan, Bruce W" <bruce.w.allan@...el.com>
To:	Jiri Slaby <jslaby@...e.cz>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>
CC:	Borislav Petkov <bp@...en8.de>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"x86@...nel.org" <x86@...nel.org>,
	lkml <linux-kernel@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>
Subject: RE: e1000e + suspend, 3.9-rc2

> -----Original Message-----
> From: Jiri Slaby [mailto:jirislaby@...il.com] On Behalf Of Jiri Slaby
> Sent: Tuesday, March 19, 2013 5:23 AM
> To: Konstantin Khlebnikov
> Cc: Borislav Petkov; Kirsher, Jeffrey T; Rafael J. Wysocki; Bjorn Helgaas;
> x86@...nel.org; lkml; e1000-devel@...ts.sourceforge.net; Allan, Bruce W
> Subject: Re: e1000e + suspend, 3.9-rc2
> 
> >>> Ok, I can still see the hardware error message when suspending:
> >>
> >> And with 3.8 plus these:
> >>      PCI/PM: Clear state_saved during suspend
> >>      e1000e: fix pci-device enable-counter balance
> >>      e1000e: fix runtime power management transitions
> >>      e1000e: fix accessing to suspended device
> >>
> >> I sometimes see this:
> >> pci_pm_suspend():e1000_suspend +0x0/0x10 [e1000e] returns -2
> >> dpm_run_callback(): pci_pm_suspend+0x0/0x140 returns -2
> >> PM: Device 0000:00:19.0 failed to suspend async: error -2
> >>
> >> Any ideas? Am I missing some patch still?
> >
> > Try this:
> > "PCI: Don't try to disable Bus Master on disconnected PCI devices"
> > https://patchwork.kernel.org/patch/2271641/
> >
> > But I'm not sure, probably it is unrelated because this code works only (?)
> > during shutdown/kexec sequences.
> 
> I don't think it will help either. -2 here is -E1000_ERR_PHY from
> e1000e_write_phy_reg_mdic if I'm looking correctly. I.e. MDIC not ready
> or unlike MDIC_ERROR.
> 
> I think this happened after I put the link down and tried to suspend.
> 
> --
> js
> suse labs

Sorry for not replying sooner, for some reason some of this thread was filtered
to my junk folder and I didn’t see it until now.

Jiri, can you provide the output of 'lspci -s 00:19.0 -n -vv' and confirm the scenario
in which the problem occurs?  Is this easily reproduced?

Thanks,
Bruce.