linux-kernel - Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOh2x==_0iR2FQFXCM2mHm28+KDj9tO4HmYMrStK_V8opmQowA@mail.gmail.com>
Date:	Fri, 29 Mar 2013 08:26:41 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Alan Stern <stern@...land.harvard.edu>, linux-usb@...r.kernel.org,
	Manjunath Goudar <manjunath.goudar@...aro.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Greg KH <greg@...ah.com>, Deepak Saxena <dsaxena@...aro.org>,
	Shiraz Hashim <shiraz.hashim@...com>, spear-devel@...t.st.com
Subject: Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

On Fri, Mar 29, 2013 at 3:25 AM, Arnd Bergmann <arnd@...db.de> wrote:
> From: Manjunath Goudar <manjunath.goudar@...aro.org>
>
> Separate the SPEAr host controller driver from ehci-hcd host code
> so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other changes are still needed before SPEAr can be
> booted with a multi-platform kernel, but they are queued in the
> arm-soc tree for 3.10.
>
> With the infrastructure added by Alan Stern in patch 3e0232039
> "USB: EHCI: prepare to make ehci-hcd a library module", we can
> avoid this problem by turning a bus glue into a separate
> module, as we do here for the SPEAr bus glue.
>
> In V3:
>  -Detailed commit message added here about why this patch is required.
>  -Eliminated ehci_spear_setup routine beacuse hcd registers
>   directly setting in spear_ehci_hcd_drv_probe function.
>  -spear_overrides struct initialized.
>  -Eliminate struct ehci_hcd ehci from struct spear_ehci,to enable SPEAr clock
>   uses directly usb_hcd *hcd in spear_start_ehci function.
>  -to_spear_ehci() macro modified for spear_ehci.
>
> In V2:
> Replaced spear as SPEAr everywhere, leaving functions/variables/config options.
>
> Signed-off-by: Deepak Saxena <dsaxena@...aro.org>
> Signed-off-by: Manjunath Goudar <manjunath.goudar@...aro.org>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Acked-by: Viresh Kumar <viresh.linux@...il.com>

This version has changed from what i Acked, but it still looks fine.

Thanks.

Viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/