linux-kernel - Re: [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO} depends on architecture symbol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130329223157.5f2adef4@crub>
Date:	Fri, 29 Mar 2013 22:31:57 +0100
From:	Anatolij Gustschin <agust@...x.de>
To:	Florian Fainelli <florian@...nwrt.org>
Cc:	stern@...land.harvard.edu, linux-kernel@...r.kernel.org,
	arnd@...db.de, gregkh@...uxfoundation.org,
	linux-usb@...r.kernel.org
Subject: Re: [RFC PATCH 2/5] USB: remove USB_EHCI_BIG_ENDIAN_{DESC,MMIO}
 depends on architecture symbol

Hello Florian,

On Tue, 26 Mar 2013 19:06:14 +0100
Florian Fainelli <florian@...nwrt.org> wrote:
...
> diff --git a/arch/powerpc/platforms/52xx/Kconfig b/arch/powerpc/platforms/52xx/Kconfig
> index 90f4496..65232cb 100644
> --- a/arch/powerpc/platforms/52xx/Kconfig
> +++ b/arch/powerpc/platforms/52xx/Kconfig
> @@ -3,6 +3,8 @@ config PPC_MPC52xx
>  	depends on 6xx
>  	select PPC_CLOCK
>  	select PPC_PCI_CHOICE
> +	select USB_EHCI_BIG_ENDIAN_MMIO
> +	select USB_EHCI_BIG_ENDIAN_DESC

Note that mpc52xx only has an OHCI controller, so this change here
is wrong. It belongs into arch/powerpc/platforms/512x/Kconfig.
mpc512x has an EHCI controller.

Thanks,

Anatolij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/