| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1364615166.3771.1.camel@phoenix> Date: Sat, 30 Mar 2013 11:46:06 +0800 From: Axel Lin <axel.lin@...ics.com> To: Thierry Reding <thierry.reding@...onic-design.de> Cc: Viresh Kumar <viresh.kumar@...aro.org>, Shiraz Hashim <shiraz.hashim@...com>, linux-kernel@...r.kernel.org Subject: [PATCH] pwm: spear: Fix enable pwm output The logic to check return value of clk_enable() is reversed, thus when clek_enable() success PWMCR_PWM_ENABLE bit is never set. Fix it. Signed-off-by: Axel Lin <axel.lin@...ics.com> --- drivers/pwm/pwm-spear.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pwm/pwm-spear.c b/drivers/pwm/pwm-spear.c index 69a2d9e..cccb430 100644 --- a/drivers/pwm/pwm-spear.c +++ b/drivers/pwm/pwm-spear.c @@ -143,7 +143,7 @@ static int spear_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm) u32 val; rc = clk_enable(pc->clk); - if (!rc) + if (rc) return rc; val = spear_pwm_readl(pc, pwm->hwpwm, PWMCR); -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists