linux-kernel - Re: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130331072506.GA7919@core.coreip.homeip.net>
Date:	Sun, 31 Mar 2013 00:25:06 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Sebastien Royen <sebastien.royen@...il.com>
Cc:	Bill Pemberton <wfp5p@...ginia.edu>, linux-kernel@...r.kernel.org,
	seb <sebastien.royen@...adeus.com>
Subject: Re: [PATCH 1/1] Input: mma8450 - fix signed 12bits to 32bits
 conversion

On Thu, Mar 28, 2013 at 03:16:29PM +0100, Sebastien Royen wrote:
> From: seb <sebastien.royen@...adeus.com>
> 
> Event value is wrong. Should be in range -2048 to 2047, but is in range 0 to 4095.
> Use s8 to int conversion and remove 0xfff mask.
> 
> Signed-off-by: Sebastien Royen <sebastien.royen@...adeus.com>

Applied, thank you Sebastien.

> ---
>  drivers/input/misc/mma8450.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/misc/mma8450.c b/drivers/input/misc/mma8450.c
> index 480557f..f330969 100644
> --- a/drivers/input/misc/mma8450.c
> +++ b/drivers/input/misc/mma8450.c
> @@ -123,9 +123,9 @@ static void mma8450_poll(struct input_polled_dev *dev)
>  	if (ret < 0)
>  		return;
>  
> -	x = ((buf[1] << 4) & 0xff0) | (buf[0] & 0xf);
> -	y = ((buf[3] << 4) & 0xff0) | (buf[2] & 0xf);
> -	z = ((buf[5] << 4) & 0xff0) | (buf[4] & 0xf);
> +	x = ((int)(s8)buf[1] << 4) | (buf[0] & 0xf);
> +	y = ((int)(s8)buf[3] << 4) | (buf[2] & 0xf);
> +	z = ((int)(s8)buf[5] << 4) | (buf[4] & 0xf);
>  
>  	input_report_abs(dev->input, ABS_X, x);
>  	input_report_abs(dev->input, ABS_Y, y);
> -- 
> 1.7.9.5
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/