lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20130331150210.GC9494@kroah.com>
Date:	Sun, 31 Mar 2013 08:02:10 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	frankie lin <frankiefrankie.lin@...il.com>
Cc:	Jiri Slaby <jslaby@...e.cz>, open <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] TTY Fix NULL pointer error in tty_wakeup

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top


On Sun, Mar 31, 2013 at 04:09:05PM +0800, frankie lin wrote:
> Hi, greg, it's excited to get your reply.
> In our case, it is gs_start_io(struct gs_port *port) in the file u_serial.c who
> call the tty_wakeup. We are trying to find the root cause.  Something is wrong
> before calling tty_wakeup, nevertheless it is reasonable to check the parameter
> first before test_bit.

No, please find the root problem here in your driver.

> To some extent, this patch can improve the robustness of function tty_wakeup,
> isn't it?

Not at the expense of papering over other bugs, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ