linux-kernel - Re: [PATCH] pwm: pxa: Remove PWM_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMPhdO9H3PzYczEYELuTk+uz5mKd8RoQiZEAQBoQTqumLWtCVA@mail.gmail.com>
Date:	Mon, 1 Apr 2013 17:09:51 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Thierry Reding <thierry.reding@...onic-design.de>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pwm: pxa: Remove PWM_ID_BASE macro

On Mon, Apr 1, 2013 at 3:41 PM, Axel Lin <axel.lin@...ics.com> wrote:
> PWM_ID_BASE() is not used after convert to PWM framework, remove it.
> Also update driver_data field of struct platform_device_id accordingly.
>
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> This is v2 of [PATCH] pwm: pxa: Use driver_data field to store pwm_nr.
> I change the subject line to meet the change in v2.
>
>  drivers/pwm/pwm-pxa.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pwm/pwm-pxa.c b/drivers/pwm/pwm-pxa.c
> index b789882..dee6ab55 100644
> --- a/drivers/pwm/pwm-pxa.c
> +++ b/drivers/pwm/pwm-pxa.c
> @@ -23,14 +23,13 @@
>  #include <asm/div64.h>
>
>  #define HAS_SECONDARY_PWM      0x10
> -#define PWM_ID_BASE(d)         ((d) & 0xf)
>
>  static const struct platform_device_id pwm_id_table[] = {
>         /*   PWM    has_secondary_pwm? */
>         { "pxa25x-pwm", 0 },
> -       { "pxa27x-pwm", 0 | HAS_SECONDARY_PWM },
> -       { "pxa168-pwm", 1 },
> -       { "pxa910-pwm", 1 },
> +       { "pxa27x-pwm", HAS_SECONDARY_PWM },
> +       { "pxa168-pwm", 0 },
> +       { "pxa910-pwm", 0 },
>         { },
>  };
>  MODULE_DEVICE_TABLE(platform, pwm_id_table);

Looks good to me, Acked-by: Eric Miao <eric.y.miao@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/