linux-kernel - Re: [PATCH 15/33] regulator: ab8500-ext: Add support for AB9540 regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130401122236.GD18636@opensource.wolfsonmicro.com>
Date:	Mon, 1 Apr 2013 13:22:36 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	linux-kernel@...r.kernel.org,
	Michel JAOUEN <michel.jaouen@...ricsson.com>
Subject: Re: [PATCH 15/33] regulator: ab8500-ext: Add support for AB9540
 regulators

On Thu, Mar 28, 2013 at 04:11:15PM +0000, Lee Jones wrote:

> +static struct regulator_ops ab9540_ext_regulator_ops = {
> +	.enable			= ab8500_ext_regulator_enable,
> +	.disable		= ab8500_ext_regulator_disable,
> +	.is_enabled		= ab8500_ext_regulator_is_enabled,
> +	.set_mode		= ab8500_ext_regulator_set_mode,
> +	.get_mode		= ab8500_ext_regulator_get_mode,
> +	.get_voltage		= ab8500_ext_fixed_get_voltage,
> +	.list_voltage		= ab8500_ext_list_voltage,
> +};
> +

> +		if (is_ab9540(ab8500) &&
> +		    ((info->desc.id == AB8500_EXT_SUPPLY1) ||
> +		     (info->desc.id == AB8500_EXT_SUPPLY2) ||
> +		     (info->desc.id == AB8500_EXT_SUPPLY3)))
> +			info->desc.ops = &ab9540_ext_regulator_ops;
> +

This appears to be identical to the ab8500, why do we need a separate
set of ops?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)