linux-kernel - Re: [PATCH] ACPI / SPI: Use parent's ACPI_HANDLE() in acpi_register_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3094287.rEsFgshmOE@vostro.rjw.lan>
Date:	Mon, 01 Apr 2013 15:30:05 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	grant.likely@...retlab.ca
Subject: Re: [PATCH] ACPI / SPI: Use parent's ACPI_HANDLE() in acpi_register_spi_devices()

On Monday, April 01, 2013 12:44:23 PM Mark Brown wrote:
> On Mon, Apr 01, 2013 at 02:21:08AM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> > 
> > The ACPI handle of struct spi_master's dev member should not be
> > set, because this causes that struct spi_master to be associated
> > with the ACPI device node corresponding to its parent as the
> > second "physical_device", which is incorrect (this happens during
> > the registration of struct spi_master).  Consequently,
> > acpi_register_spi_devices() should use the ACPI handle of the
> > parent of the struct spi_master it is called for rather than that
> > struct spi_master's ACPI handle (which should be NULL).
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> or does this need to be applied to the SPI tree?

I can push it through the PM/ACPI tree along with an analogous I2C patch.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/