linux-kernel - [PATCH] drivers/usb/serial: looping issue: avoid the return value overriden by looping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5159041F.7020608@asianux.com>
Date:	Mon, 01 Apr 2013 11:50:55 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	jhovold@...il.com, Jiri Slaby <jslaby@...e.cz>,
	mferrell@...ogix.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] drivers/usb/serial: looping issue: avoid the return value
 overriden by looping


  inside the 'for' looping:
    the return value 'rv' may override if not have a check in time.

  next checking, outside the 'for' looping:
    can not find failure which generated during the 'for' looping

  so need let outside know about the failure.


Signed-off-by: Chen Gang <gang.chen@...anux.com>
---
 drivers/usb/serial/mos7840.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index a0d5ea5..13aae1e 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -651,7 +651,9 @@ static void mos7840_interrupt_callback(struct urb *urb)
 					wreg = MODEM_STATUS_REGISTER;
 					break;
 				}
-				rv = mos7840_get_reg(mos7840_port, wval, wreg, &Data);
+				if (mos7840_get_reg(mos7840_port, wval,
+				    wreg, &Data) < 0)
+					rv = -1;
 			}
 		}
 	}
-- 
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/