linux-kernel - Re: [PATCH] checkpatch: do not exit in main process subroutine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1364788537.8705.10.camel@ubuntu>
Date:	Sun, 31 Mar 2013 21:55:37 -0600
From:	Joe Perches <joe@...ches.com>
To:	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Cc:	Andy Whitcroft <apw@...onical.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: do not exit in main process subroutine

On Sat, 2013-03-30 at 18:30 +0800, zhangwei(Jovi) wrote:
> On 2013/3/28 11:43, zhangwei(Jovi) wrote:
> > Currently checkpatch program exit when process empty file,
> > This will cause issue when @ARGV include many files ready to check.
[]
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > @@ -3634,19 +3634,19 @@ sub process {
> >  	# If we have no input at all, then there is nothing to report on
> >  	# so just keep quiet.
> >  	if ($#rawlines == -1) {
> > -		exit(0);
> > +		return $clean;
> >  	}

I think instead this should be something like adding

	if (!is_patch && $#rawlines == -1) {
		return $clean;
	}

though maybe expecting checkpatch to avoid empty files
when fed a directory list is unrealistic.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/