linux-kernel - Re: [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 01 Apr 2013 21:31:38 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [TRIVIAL] Remove obsolete, iSeries specific, Makefile
 lines

On Sun, 2013-03-31 at 17:47 +0200, Jiri Kosina wrote:
> I believe you could remove all the corresponding major number defines from 
> include/uapi/linux/major.h while you are at it.

0) You seem to mean these:
    $ grep VIO include/uapi/linux/major.h
    #define VIODASD_MAJOR		112
    #define VIOCD_MAJOR		113
    #define VIOTAPE_MAJOR		230

They are indeed unused. But are they safe to be removed? I'm always very
cautious with touching magic numbers, and the like (even obsolete).

1) Anyhow, if they really can be removed, I prefer to do that in a
separate patch.


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/