linux-kernel - Re: [PATCH 04/27] perf tools: Move programs check into config/Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1364854190.1728.12.camel@leonhard>
Date:	Tue, 02 Apr 2013 07:09:50 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Borislav Petkov <bp@...en8.de>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 04/27] perf tools: Move programs check into
 config/Makefile

2013-04-01 (월), 21:18 +0200, Jiri Olsa:
> Moving programs check into config/Makefile.

[SNIP]

> +RM      = rm -f
> +MKDIR   = mkdir
> +FIND    = find
> +INSTALL = install
> +FLEX    = flex
> +BISON   = bison
> +STRIP  ?= strip

Why does STRIP use "?=" form?

I know you just moved the line, but AFAICS it can be converted to a
normal variable assignment, right?


> @@ -140,14 +140,6 @@ ifneq ($(MAKECMDGOALS),clean)
>  ifneq ($(MAKECMDGOALS),tags)
>  -include config/feature-tests.mak
>  
> -ifeq ($(call get-executable,$(FLEX)),)
> -	dummy := $(error Error: $(FLEX) is missing on this system, please install it)
> -endif
> -
> -ifeq ($(call get-executable,$(BISON)),)
> -	dummy := $(error Error: $(BISON) is missing on this system, please install it)
> -endif
> -
>  ifeq ($(call try-cc,$(SOURCE_HELLO),$(CFLAGS) -Werror -fstack-protector-all,-fstack-protector-all),y)
>  	CFLAGS := $(CFLAGS) -fstack-protector-all
>  endif
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index fe317c2..04bf8ac 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -32,3 +32,13 @@ endif
>  ifeq ($(NO_PERF_REGS),0)
>          BASIC_CFLAGS += -DHAVE_PERF_REGS
>  endif
> +
> +-include config/feature-tests.mak

It seems now it's redundant to include this file?

Thanks,
Namhyung


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/