linux-kernel - Re: [PATCH 1/5] power: ds2782_battery: Use dev_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130401060052.GA30190@lizard>
Date:	Sun, 31 Mar 2013 23:00:52 -0700
From:	Anton Vorontsov <anton@...msg.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org, Evgeny Romanov <romanov@...rosoft.ru>
Subject: Re: [PATCH 1/5] power: ds2782_battery: Use dev_pm_ops

On Sun, Mar 10, 2013 at 02:34:05PM +0100, Lars-Peter Clausen wrote:
> Use dev_pm_ops instead of the deprecated legacy suspend/resume callbacks.
> 
> Cc: Evgeny Romanov <romanov@...rosoft.ru>
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> ---
[...]
> @@ -465,11 +466,10 @@ MODULE_DEVICE_TABLE(i2c, ds278x_id);
>  static struct i2c_driver ds278x_battery_driver = {
>  	.driver 	= {
>  		.name	= "ds2782-battery",
> +		.pm	= DS278X_BATERY_PM_OPS,

Typo: BATTERY.

  CHECK   drivers/power/ds2782_battery.c
drivers/power/ds2782_battery.c:464:27: error: undefined identifier 'DS278X_BATERY_PM_OPS'
  CC      drivers/power/ds2782_battery.o
drivers/power/ds2782_battery.c:464:9: error: ‘DS278X_BATERY_PM_OPS’ undeclared here (not in a function)
make[1]: *** [drivers/power/ds2782_battery.o] Error 1

I fixed it up and applied the patch...

Thanks,

Anton

>  	},
>  	.probe		= ds278x_battery_probe,
>  	.remove		= ds278x_battery_remove,
> -	.suspend	= ds278x_suspend,
> -	.resume		= ds278x_resume,
>  	.id_table	= ds278x_id,
>  };
>  module_i2c_driver(ds278x_battery_driver);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/