| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130402230323.GB8713@kroah.com> Date: Tue, 2 Apr 2013 16:03:23 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Jacob Pan <jacob.jun.pan@...ux.intel.com> Cc: LKML <linux-kernel@...r.kernel.org>, Platform Driver <platform-driver-x86@...r.kernel.org>, Matthew Garrett <matthew.garrett@...ula.com>, Zhang Rui <rui.zhang@...el.com>, Rafael Wysocki <rafael.j.wysocki@...el.com>, Len Brown <len.brown@...el.com>, Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>, Arjan van de Ven <arjan@...ux.intel.com> Subject: Re: [PATCH 1/1] Introduce Intel RAPL cooling device driver On Tue, Apr 02, 2013 at 04:00:42PM -0700, Greg KH wrote: > I'm not even going to review the rest of this file, please fix that up > first, before sending it out again. And, when you do so, please cc: me. It's like a train wreck, you just can't tear away your eyes... You race with userspace in the creation of your sysfs files. Your device is announced to userspace and then, later on, you create the sysfs files. This means that tools like libudev never sees your files, so the attributes aren't read properly by loads of userspace programs that you want to have read them. Please fix that before resending this as well. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists