linux-kernel - Re: [PATCH v2, part1 16/29] mm/openrisc: use common help functions to free reserved pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACM3HyFn-DZukNtftCCQmLBEBvQ4GZdgc1wu-hPsyq-qX2Ef0w@mail.gmail.com>
Date:	Tue, 2 Apr 2013 07:31:35 +0200
From:	Jonas Bonn <jonas@...thpole.se>
To:	Jiang Liu <liuj97@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	David Rientjes <rientjes@...gle.com>,
	Jiang Liu <jiang.liu@...wei.com>,
	Wen Congyang <wency@...fujitsu.com>,
	Maciej Rutecki <maciej.rutecki@...il.com>,
	Chris Clayton <chris2553@...glemail.com>,
	"Rafael J . Wysocki" <rjw@...k.pl>, Mel Gorman <mgorman@...e.de>,
	Minchan Kim <minchan@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	Jianguo Wu <wujianguo@...wei.com>, linux-mm@...ck.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2, part1 16/29] mm/openrisc: use common help functions to
 free reserved pages

On 10 March 2013 07:26, Jiang Liu <liuj97@...il.com> wrote:
> Use common help functions to free reserved pages.
> Also include <asm/sections.h> to avoid local declarations.
>
> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
> Cc: Jonas Bonn <jonas@...thpole.se>

Tested and works fine on OpenRISC.

Acked-by: Jonas Bonn <jonas@...thpole.se>

/Jonas

> ---
>  arch/openrisc/mm/init.c |   27 +++------------------------
>  1 file changed, 3 insertions(+), 24 deletions(-)
>
> diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c
> index e7fdc50..b3cbc67 100644
> --- a/arch/openrisc/mm/init.c
> +++ b/arch/openrisc/mm/init.c
> @@ -43,6 +43,7 @@
>  #include <asm/kmap_types.h>
>  #include <asm/fixmap.h>
>  #include <asm/tlbflush.h>
> +#include <asm/sections.h>
>
>  int mem_init_done;
>
> @@ -201,9 +202,6 @@ void __init paging_init(void)
>
>  /* References to section boundaries */
>
> -extern char _stext, _etext, _edata, __bss_start, _end;
> -extern char __init_begin, __init_end;
> -
>  static int __init free_pages_init(void)
>  {
>         int reservedpages, pfn;
> @@ -263,30 +261,11 @@ void __init mem_init(void)
>  #ifdef CONFIG_BLK_DEV_INITRD
>  void free_initrd_mem(unsigned long start, unsigned long end)
>  {
> -       printk(KERN_INFO "Freeing initrd memory: %ldk freed\n",
> -              (end - start) >> 10);
> -
> -       for (; start < end; start += PAGE_SIZE) {
> -               ClearPageReserved(virt_to_page(start));
> -               init_page_count(virt_to_page(start));
> -               free_page(start);
> -               totalram_pages++;
> -       }
> +       free_reserved_area(start, end, 0, "initrd");
>  }
>  #endif
>
>  void free_initmem(void)
>  {
> -       unsigned long addr;
> -
> -       addr = (unsigned long)(&__init_begin);
> -       for (; addr < (unsigned long)(&__init_end); addr += PAGE_SIZE) {
> -               ClearPageReserved(virt_to_page(addr));
> -               init_page_count(virt_to_page(addr));
> -               free_page(addr);
> -               totalram_pages++;
> -       }
> -       printk(KERN_INFO "Freeing unused kernel memory: %luk freed\n",
> -              ((unsigned long)&__init_end -
> -               (unsigned long)&__init_begin) >> 10);
> +       free_initmem_default(0);
>  }
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/