linux-kernel - RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A24364150E8B3B7@penmbx01>
Date:	Tue, 2 Apr 2013 06:17:06 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	"Yang, Wenyou" <Wenyou.Yang@...el.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"richard.genoud@...il.com" <richard.genoud@...il.com>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"Lin, JM" <JM.Lin@...el.com>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address

Hi, Mark,

> -----Original Message-----
> From: Yang, Wenyou
> Sent: 2013年4月2日 13:50
> To: 'Mark Brown'
> Cc: linux-arm-kernel@...ts.infradead.org; grant.likely@...retlab.ca;
> richard.genoud@...il.com; plagnioj@...osoft.com; Ferre, Nicolas; Lin, JM;
> spi-devel-general@...ts.sourceforge.net; linux-kernel@...r.kernel.org
> Subject: RE: [PATCH v7 03/14] spi/spi-atmel: add physical base address
> 
> Hi, Mark,
> 
> > -----Original Message-----
> > From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> > Sent: 2013年4月1日 21:42
> > To: Yang, Wenyou
> > Cc: linux-arm-kernel@...ts.infradead.org; grant.likely@...retlab.ca;
> > richard.genoud@...il.com; plagnioj@...osoft.com; Ferre, Nicolas; Lin, JM;
> > spi-devel-general@...ts.sourceforge.net; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v7 03/14] spi/spi-atmel: add physical base address
> >
> > On Tue, Mar 19, 2013 at 03:43:36PM +0800, Wenyou Yang wrote:
> >
> > > +++ b/drivers/spi/spi-atmel.c
> > > @@ -196,6 +196,7 @@ struct atmel_spi_caps {  struct atmel_spi {
> > >  	spinlock_t		lock;
> > >
> > > +	resource_size_t		phybase;
> > >  	void __iomem		*regs;
> > >  	int			irq;
> > >  	struct clk		*clk;
> >
> > This looks like the wrong type?
> 
I got it, you are right, you mean It should be used " phys_addr_t " type.

	phys_addr_t	phybase;

Thanks.

Best Regards,
Wenyou Yang.

> I double checked.
> 
> The type ' resource_size_t ' is defined in include/linux/ types.h as below,
> 
> typedef phys_addr_t resource_size_t;
> 
> I think it is OK.
> 
> Best Regards,
> Wenyou Yang