linux-kernel - Re: [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130402084808.0c6d61f8@mschwide>
Date:	Tue, 2 Apr 2013 08:48:08 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Tejun Heo <tj@...nel.org>, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...hat.com, x86@...nel.org, rth@...ddle.net,
	linux@....linux.org.uk, msalter@...hat.com, starvik@...s.com,
	dhowells@...hat.com, tony.luck@...el.com, benh@...nel.crashing.org,
	takata@...ux-m32r.org, geert@...ux-m68k.org,
	james.hogan@...tec.com, monstr@...str.eu, ralf@...ux-mips.org,
	jonas@...thpole.se, rkuo@...eaurora.org, liqin.chen@...plusct.com,
	davem@...emloft.net, lethal@...ux-sh.org, vgupta@...opsys.com,
	chris@...kel.net, cmetcalf@...era.com, ysato@...rs.sourceforge.jp,
	gxt@...c.pku.edu.cn, jdike@...toit.com, linux-s390@...r.kernel.org,
	Mike Frysinger <vapier@...too.org>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 3/5] dump_stack: consolidate dump_stack()
 implementations and unify their behaviors

On Sat, 30 Mar 2013 12:45:35 +0100
Heiko Carstens <heiko.carstens@...ibm.com> wrote:

> On Fri, Mar 29, 2013 at 07:27:06PM -0700, Tejun Heo wrote:
> > Both dump_stack() and show_stack() are currently implemented by each
> > architecture.  show_stack(NULL, NULL) dumps the backtrace for the
> > current task as does dump_stack().  On some archs, dump_stack() prints
> > extra information - pid, utsname and so on - in addition to the
> > backtrace while the two are identical on other archs.
> 
> [...]
> 
> > This patch expands the dummy fallback dump_stack() implementation in
> > lib/dump_stack.c such that it prints out debug information (taken from
> > x86) and invokes show_stack(NULL, NULL) and drops arch-specific
> > dump_stack() implementations in all archs except blackfin and s390.
> > Blackfin's dump_stack() does something wonky that I don't understand
> > and s390 prints its own debug information which includes fields which
> > aren't accessible from arch-indepdent code.
> 
> The couple of extra fields aren't worth an s390 version of dump_stack()
> that differs from all other architectures.
> Please drop the s390 version as well. Thanks!

Hmm, we would lose task_thread_info(current)->cpu and current->thread.ksp,
I don't care much about the kernel stack pointer which has been stored at
the last call to __switch_to but the cpu number might be interesting.
Could we add the cpu number to the generic dump_stack version?

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/