linux-kernel - Re: [PATCH v2] cs5535-mfgpt: Add another reset method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130402181728.1c3f92fc8727a39e1145c688@canb.auug.org.au>
Date:	Tue, 2 Apr 2013 18:17:28 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Richard Weinberger <richard@....at>
Cc:	greg@...ah.com, arnd@...db.de, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cs5535-mfgpt: Add another reset method

Hi Richard,

On Tue,  2 Apr 2013 08:46:37 +0200 Richard Weinberger <richard@....at> wrote:
>
> The CS5535/CS5536 MFGPT has no support to reset the device.
> The current method uses an undocumented bit but does not work on all
> devices. At least on my ALIX board it completely freezes the board.
> 
> This new method tries to soft reset all timers by unconfiguring them.
> But this does not clear the RO setup register and therefore it has to
> be ignored while probing.
> 
> Resetting the timers is not only needed on broken BIOSes also when
> kexec is used. Otherwise the new kernel will find preconfigured timers
> and odd things will happen.
> 
> Signed-off-by: Richard Weinberger <richard@....at>
> ---
>  drivers/misc/cs5535-mfgpt.c | 41 +++++++++++++++++++++++++++++++++++++----
>  1 file changed, 37 insertions(+), 4 deletions(-)

Greg will probably want an incremental fix patch as he does not rewrite
his trees.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped