linux-kernel - Re: [PATCH] sound: oss: sb_common: Used kmemdup instead of kmalloc and memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hli918ew7.wl%tiwai@suse.de>
Date:	Tue, 02 Apr 2013 11:23:36 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Alexandru Gheorghiu <gheorghiuandru@...il.com>
Cc:	Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: oss: sb_common: Used kmemdup instead of kmalloc and memcpy

At Mon, 25 Mar 2013 15:50:34 +0200,
Alexandru Gheorghiu wrote:
> 
> Used kmemdup instead of replicating it's behaviour with kmalloc followed
> by memcpy.
> Patch found using coccinelle.
> 
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@...il.com>

Thanks, applied.


Takashi


> ---
>  sound/oss/sb_common.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/oss/sb_common.c b/sound/oss/sb_common.c
> index 7d42c54..851a1da 100644
> --- a/sound/oss/sb_common.c
> +++ b/sound/oss/sb_common.c
> @@ -626,13 +626,12 @@ int sb_dsp_detect(struct address_info *hw_config, int pci, int pciio, struct sb_
>  	 */
>  
>  
> -	detected_devc = kmalloc(sizeof(sb_devc), GFP_KERNEL);
> +	detected_devc = kmemdup(devc, sizeof(sb_devc), GFP_KERNEL);
>  	if (detected_devc == NULL)
>  	{
>  		printk(KERN_ERR "sb: Can't allocate memory for device information\n");
>  		return 0;
>  	}
> -	memcpy(detected_devc, devc, sizeof(sb_devc));
>  	MDB(printk(KERN_INFO "SB %d.%02d detected OK (%x)\n", devc->major, devc->minor, hw_config->io_base));
>  	return 1;
>  }
> -- 
> 1.7.9.5
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/