linux-kernel - Re: [PATCH 10/23] perf: make demangle support based on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Apr 2013 11:26:58 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	David Ahern <dsahern@...il.com>
Cc:	acme@...stprotocols.net, linux-kernel@...r.kernel.org,
	Borislav Petkov <bp@...en8.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 10/23] perf: make demangle support based on
 CONFIG_DEMANGLE

On Mon, 2013-04-01 at 21:54 -0600, David Ahern wrote:
> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> index 5c060c8..65283e6 100644
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
>[...]
> @@ -571,7 +569,9 @@ ifdef CONFIG_LIBELF
>  	endif
>  else
>      NO_DWARF := 1
> -    NO_DEMANGLE := 1
> +    ifdef CONFIG_DEMANGLE
> +        $(error CONFIG_DEMANGLE depends on LIBELF)
> +    endif

You check for a dependency here ...

>      ifdef CONFIG_LIBUNWIND
>          $(error CONFIG_LIBUNWIND depends on LIBELF)
>      endif
>[...]
> diff --git a/tools/perf/Pconfig b/tools/perf/Pconfig
> index d6e067e..dc0fc36 100644
> --- a/tools/perf/Pconfig
> +++ b/tools/perf/Pconfig
> @@ -26,6 +26,10 @@ config LIBUNWIND
>      bool "Enable support for libunwind"
>      depends on HAVE_CFI_UNWIND_SUPPORT && LIBELF
>  
> + config DEMANGLE
> +    bool "Enable support for demangle"
> +    depends on LIBELF
> +

... that already seems to be enforced here.

>  config LIBPERL
>      bool "Enable support for perl scripting engine"
>  


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/