linux-kernel - Re: [PATCH v2] davinci: vpif: add pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8uZn+bZt58TFP3FN5BB2cWMFPG=yMMB7CdUMujXDmoxPw@mail.gmail.com>
Date:	Tue, 2 Apr 2013 16:28:32 +0530
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Sakari Ailus <sakari.ailus@....fi>,
	Sekhar Nori <nsekhar@...com>
Subject: Re: [PATCH v2] davinci: vpif: add pm_runtime support

Hi Hans,

On Tue, Apr 2, 2013 at 2:17 PM, Hans Verkuil <hverkuil@...all.nl> wrote:
> On Mon 1 April 2013 08:36:50 Prabhakar lad wrote:
>> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
>>
>> Add pm_runtime support to the TI Davinci VPIF driver.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
>> Cc: Mauro Carvalho Chehab <mchehab@...hat.com>
>> Cc: Hans Verkuil <hans.verkuil@...co.com>
>> Cc: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>> Cc: Sakari Ailus <sakari.ailus@....fi>
>> Cc: Sekhar Nori <nsekhar@...com>
>> ---
>>  Changes for v2:
>>  1: Removed use of clk API as pointed by Laurent and Sekhar.
>>
>>  drivers/media/platform/davinci/vpif.c |   24 +++++++-----------------
>>  1 files changed, 7 insertions(+), 17 deletions(-)
>>
>> diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
>> index 28638a8..599cabb 100644
>> --- a/drivers/media/platform/davinci/vpif.c
>> +++ b/drivers/media/platform/davinci/vpif.c
>> @@ -23,8 +23,8 @@
>>  #include <linux/spinlock.h>
>>  #include <linux/kernel.h>
>>  #include <linux/io.h>
>> -#include <linux/clk.h>
>>  #include <linux/err.h>
>> +#include <linux/pm_runtime.h>
>>  #include <linux/v4l2-dv-timings.h>
>>
>>  #include <mach/hardware.h>
>> @@ -44,7 +44,6 @@ static struct resource      *res;
>>  spinlock_t vpif_lock;
>>
>>  void __iomem *vpif_base;
>> -struct clk *vpif_clk;
>>
>>  /**
>>   * ch_params: video standard configuration parameters for vpif
>> @@ -439,19 +438,15 @@ static int vpif_probe(struct platform_device *pdev)
>>               goto fail;
>>       }
>>
>> -     vpif_clk = clk_get(&pdev->dev, "vpif");
>> -     if (IS_ERR(vpif_clk)) {
>> -             status = PTR_ERR(vpif_clk);
>> -             goto clk_fail;
>> -     }
>> -     clk_prepare_enable(vpif_clk);
>> +     pm_runtime_enable(&pdev->dev);
>> +     pm_runtime_resume(&pdev->dev);
>> +
>> +     pm_runtime_get(&pdev->dev);
>
> pm_runtime_get() calls pm_runtime_resume() if needed, so is the call to resume()
> really necessary?
>
Agreed I'll drop the call to pm_runtime_resume() and post a v3.

Regards,
--Prabhakar

> Regards,
>
>         Hans
>
>>
>>       spin_lock_init(&vpif_lock);
>>       dev_info(&pdev->dev, "vpif probe success\n");
>>       return 0;
>>
>> -clk_fail:
>> -     iounmap(vpif_base);
>>  fail:
>>       release_mem_region(res->start, res_len);
>>       return status;
>> @@ -459,11 +454,6 @@ fail:
>>
>>  static int vpif_remove(struct platform_device *pdev)
>>  {
>> -     if (vpif_clk) {
>> -             clk_disable_unprepare(vpif_clk);
>> -             clk_put(vpif_clk);
>> -     }
>> -
>>       iounmap(vpif_base);
>>       release_mem_region(res->start, res_len);
>>       return 0;
>> @@ -472,13 +462,13 @@ static int vpif_remove(struct platform_device *pdev)
>>  #ifdef CONFIG_PM
>>  static int vpif_suspend(struct device *dev)
>>  {
>> -     clk_disable_unprepare(vpif_clk);
>> +     pm_runtime_put(dev);
>>       return 0;
>>  }
>>
>>  static int vpif_resume(struct device *dev)
>>  {
>> -     clk_prepare_enable(vpif_clk);
>> +     pm_runtime_get(dev);
>>       return 0;
>>  }
>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/